This repository was archived by the owner on Aug 4, 2021. It is now read-only.
Add index.d.ts typings file #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@NotWoods if you're up for fixing the conflict, I'll merge this immediately. |
Member
Author
|
Updated! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My continued efforts to fully support typechecking a Rollup config with TypeScript.
TypeScript allows for checking normal Javascript files by adding a
// @ts-checkcomment at the top of the file. By providing typings users can check that they aren't passing misspelled or incorrect parameters, and see a hint about what each option does in their editor.Fixes #137
Since the plugin accepts the same options as TypeScript's compiler options, I initially experimented with extending the exported
CompilerOptionstype. Unfortunately that interface doesn't match up with the JSON schema, and uses enums for certain values liketarget. I ended up just using an index type instead, although the types are slightly weaker. TypeScript just usesanyfor its JSON parsing function so this should be fine.